Messages in this thread | | | From | "Edgecombe, Rick P" <> | Subject | Re: [PATCH 1/3] x86: Separate out x86_regset for 32 and 64 bit | Date | Tue, 15 Mar 2022 23:33:31 +0000 |
| |
On Tue, 2022-03-15 at 18:01 -0500, Eric W. Biederman wrote: > So I am looking at this and am wondering if the enums should be: > > enum x86_32_regset { > REGSET32_GENERAL, > REGSET32_FP, > REGSET32_XFP, > REGSET32_XSTATE, > REGSET32_TLS, > REGSET32_IOPERM32, > }; > > enum x86_64_regset { > REGSET64_GENERAL, > REGSET64_FP, > REGSET64_IOPERM64, > REGSET64_XSTATE, > }; > > > That is named in such a way that it emphasizes that the difference is > the architecture. Otherwise it reads like the difference is the size > of > the registers in the regset. I am pretty certain that in your > REGSET_FP32 and REGSET_FP64 all of the registers are 80 bits long.
Yes, that makes sense. I had just copied the format of REGSET_IOPERM32/REGSET_IOPERM64, but I'll change it like you suggest here.
Thanks,
Rick
| |