lkml.org 
[lkml]   [2022]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH v5 010/104] KVM: TDX: Make TDX VM type supported
From
Date
On Tue, 2022-03-15 at 14:03 -0700, Isaku Yamahata wrote:
> On Mon, Mar 14, 2022 at 12:08:59PM +1300,
> Kai Huang <kai.huang@intel.com> wrote:
>
> > On Fri, 2022-03-04 at 11:48 -0800, isaku.yamahata@intel.com wrote:
> > > From: Isaku Yamahata <isaku.yamahata@intel.com>
> > >
> > > As first step TDX VM support, return that TDX VM type supported to device
> > > model, e.g. qemu. The callback to create guest TD is vm_init callback for
> > > KVM_CREATE_VM. Add a place holder function and call a function to
> > > initialize TDX module on demand because in that callback VMX is enabled by
> > > hardware_enable callback (vmx_hardware_enable).
> >
> > Should we put this patch at the end of series until all changes required to run
> > TD are introduced? This patch essentially tells userspace KVM is ready to
> > support a TD but actually it's not ready. And this might also cause bisect
> > issue I suppose?
>
> The intention is that developers can exercise the new code step-by-step even if
> the TDX KVM isn't complete.

What is the purpose/value to allow developers to exercise the new code step-by-
step? Userspace cannot create TD successfully anyway until all patches are
ready.

--
Thanks,
-Kai

\
 
 \ /
  Last update: 2022-03-15 22:48    [W:0.150 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site