lkml.org 
[lkml]   [2022]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 054/121] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 2ac5b58e645c66932438bb021cb5b52097ce70b0 ]

    The of_find_compatible_node() function returns a node pointer with
    refcount incremented, We should use of_node_put() on it when done
    Add the missing of_node_put() to release the refcount.

    Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
    Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>
    Link: https://lore.kernel.org/r/20220310015313.14938-1-linmq006@gmail.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/freescale/gianfar_ethtool.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c
    index 7b32ed29bf4c..8c17fe5d66ed 100644
    --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c
    +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
    @@ -1460,6 +1460,7 @@ static int gfar_get_ts_info(struct net_device *dev,
    ptp_node = of_find_compatible_node(NULL, NULL, "fsl,etsec-ptp");
    if (ptp_node) {
    ptp_dev = of_find_device_by_node(ptp_node);
    + of_node_put(ptp_node);
    if (ptp_dev)
    ptp = platform_get_drvdata(ptp_dev);
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-03-14 13:37    [W:3.120 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site