lkml.org 
[lkml]   [2022]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 037/121] ice: Dont use GFP_KERNEL in atomic context
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 3d97f1afd8d831e0c0dc1157418f94b8faa97b54 ]

    ice_misc_intr() is an irq handler. It should not sleep.

    Use GFP_ATOMIC instead of GFP_KERNEL when allocating some memory.

    Fixes: 348048e724a0 ("ice: Implement iidc operations")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Tested-by: Leszek Kaliszczuk <leszek.kaliszczuk@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
    index fc04b4cf4ae0..676e837d48cf 100644
    --- a/drivers/net/ethernet/intel/ice/ice_main.c
    +++ b/drivers/net/ethernet/intel/ice/ice_main.c
    @@ -3016,7 +3016,7 @@ static irqreturn_t ice_misc_intr(int __always_unused irq, void *data)
    struct iidc_event *event;

    ena_mask &= ~ICE_AUX_CRIT_ERR;
    - event = kzalloc(sizeof(*event), GFP_KERNEL);
    + event = kzalloc(sizeof(*event), GFP_ATOMIC);
    if (event) {
    set_bit(IIDC_EVENT_CRIT_ERR, event->type);
    /* report the entire OICR value to AUX driver */
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-03-14 13:29    [W:4.129 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site