lkml.org 
[lkml]   [2022]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 100/110] watch_queue: Make comment about setting ->defunct more accurate
    Date
    From: David Howells <dhowells@redhat.com>

    commit 4edc0760412b0c4ecefc7e02cb855b310b122825 upstream.

    watch_queue_clear() has a comment stating that setting ->defunct to true
    preventing new additions as well as preventing notifications. Whilst
    the latter is true, the first bit is superfluous since at the time this
    function is called, the pipe cannot be accessed to add new event
    sources.

    Remove the "new additions" bit from the comment.

    Fixes: c73be61cede5 ("pipe: Add general notification queue support")
    Reported-by: Jann Horn <jannh@google.com>
    Signed-off-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    kernel/watch_queue.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/kernel/watch_queue.c
    +++ b/kernel/watch_queue.c
    @@ -569,7 +569,7 @@ void watch_queue_clear(struct watch_queu
    rcu_read_lock();
    spin_lock_bh(&wqueue->lock);

    - /* Prevent new additions and prevent notifications from happening */
    + /* Prevent new notifications from being stored. */
    wqueue->defunct = true;

    while (!hlist_empty(&wqueue->watches)) {

    \
     
     \ /
      Last update: 2022-03-14 13:25    [W:4.217 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site