lkml.org 
[lkml]   [2022]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [v3 19/19] ASoC: mediatek: mt6358: add missing EXPORT_SYMBOLs
    From
    Il 13/03/22 16:10, Jiaxin Yu ha scritto:
    > This fixes the following build errors when mt6358 is configured as module:
    >
    >>> ERROR: modpost: "mt6358_set_mtkaif_protocol"
    >>> [sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.ko] undefined!
    >>> ERROR: modpost: "mt6358_set_mtkaif_protocol"
    >>> [sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.ko] undefined!
    >
    > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>

    Hello Jiaxin,

    Can you please add a Fixes tag to this patch and send it separately from
    the MT8186 series?

    After adding the Fixes tag:
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

    Thanks,
    Angelo

    > ---
    > sound/soc/codecs/mt6358.c | 4 ++++
    > 1 file changed, 4 insertions(+)
    >
    > diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c
    > index 1fdd2f8cf877..61f2a7632fd4 100644
    > --- a/sound/soc/codecs/mt6358.c
    > +++ b/sound/soc/codecs/mt6358.c
    > @@ -107,6 +107,7 @@ int mt6358_set_mtkaif_protocol(struct snd_soc_component *cmpnt,
    > priv->mtkaif_protocol = mtkaif_protocol;
    > return 0;
    > }
    > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_protocol);
    >
    > static void playback_gpio_set(struct mt6358_priv *priv)
    > {
    > @@ -273,6 +274,7 @@ int mt6358_mtkaif_calibration_enable(struct snd_soc_component *cmpnt)
    > 1 << RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT);
    > return 0;
    > }
    > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_enable);
    >
    > int mt6358_mtkaif_calibration_disable(struct snd_soc_component *cmpnt)
    > {
    > @@ -296,6 +298,7 @@ int mt6358_mtkaif_calibration_disable(struct snd_soc_component *cmpnt)
    > capture_gpio_reset(priv);
    > return 0;
    > }
    > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_disable);
    >
    > int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component *cmpnt,
    > int phase_1, int phase_2)
    > @@ -310,6 +313,7 @@ int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component *cmpnt,
    > phase_2 << RG_AUD_PAD_TOP_PHASE_MODE2_SFT);
    > return 0;
    > }
    > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_calibration_phase);
    >
    > /* dl pga gain */
    > enum {

    \
     
     \ /
      Last update: 2022-03-14 11:18    [W:2.172 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site