Messages in this thread Patch in this message | | | From | Haowen Bai <> | Subject | [PATCH] s390/tape: Use bitwise instead of arithmetic operator for flags | Date | Tue, 15 Mar 2022 10:24:43 +0800 |
| |
This silences the following coccinelle warning: drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
Signed-off-by: Haowen Bai <baihaowen@meizu.com> --- drivers/s390/char/tape_34xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/char/tape_34xx.c b/drivers/s390/char/tape_34xx.c index 7ada994..487ad2d 100644 --- a/drivers/s390/char/tape_34xx.c +++ b/drivers/s390/char/tape_34xx.c @@ -354,10 +354,10 @@ tape_34xx_unit_check(struct tape_device *device, struct tape_request *request, if (( sense[0] == SENSE_DATA_CHECK || sense[0] == SENSE_EQUIPMENT_CHECK || - sense[0] == SENSE_EQUIPMENT_CHECK + SENSE_DEFERRED_UNIT_CHECK + sense[0] == SENSE_EQUIPMENT_CHECK | SENSE_DEFERRED_UNIT_CHECK ) && ( sense[1] == SENSE_DRIVE_ONLINE || - sense[1] == SENSE_BEGINNING_OF_TAPE + SENSE_WRITE_MODE + sense[1] == SENSE_BEGINNING_OF_TAPE | SENSE_WRITE_MODE )) { switch (request->op) { /* -- 2.7.4
| |