lkml.org 
[lkml]   [2022]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 1/8] dt-bindings: pinctrl: mvebu: Document bindings for AC5
Date

On 15/03/22 13:07, Andrew Lunn wrote:
>> + properties:
>> + marvell,function:
>> + $ref: "/schemas/types.yaml#/definitions/string"
>> + description:
>> + Indicates the function to select.
>> + enum: [ gpio, i2c0, i2c1, nand, sdio, spi0, spi1, uart0, uart1, uart2, uart3 ]
>> +
>> + marvell,pins:
>> + $ref: /schemas/types.yaml#/definitions/string-array
>> + description:
>> + Array of MPP pins to be used for the given function.
>> + minItems: 1
> Now that i've looked at the .txt files, i'm wondering if this should
> be split into a marvell,mvebu-pinctrl.yaml and
> marvell,ac5-pinctrl.yaml?
>
> I don't know yaml well enough to know if this is possible. All the
> mvebu pinctrl drivers have marvell,function and marvell,pins. The enum
> will differ, this ethernet switch SoC does not have sata, audio etc,
> where as the general purpose Socs do. Can that be represented in yaml?

I think it can. I vaguely remember seeing conditional clauses based on
compatible strings in other yaml bindings.

I started a new binding document because I expected adding significant
additions to the existing .txt files would be rejected. If I get some
cycles I could look at converting the existing docs from txt to yaml.

I'm not sure that there will be much in the way of a common
mvebu-pinctrl.yaml as you'd end up repeating most of the common stuff to
make things conditional anyway.

>
> Andrew
\
 
 \ /
  Last update: 2022-03-15 01:23    [W:0.114 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site