Messages in this thread | | | From | Alviro Iskandar Setiawan <> | Date | Tue, 15 Mar 2022 06:38:19 +0700 | Subject | Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning |
| |
On Tue, Mar 15, 2022 at 5:07 AM Nathan Chancellor wrote: > Hi Alviro, [...] > > I would recommend removing these and just setting those values via git > send-email flags. In other words: > > git send-email --to "..." --cc "..." --cc "..." <path to .patch> > > and so on. It can cause a lot of spam if this patch is ever backported > or needed in other trees.
Fixed.
> > Reported-by: kernel test robot <lkp@intel.com> > > Link: https://lore.kernel.org/lkml/202203091430.MLY27Bif-lkp@intel.com > > Fixes: 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver") > > This should be simplified to: > > Fixes: 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver") > > I don't think the automated checkers will complain about that but the > short form is preferred.
Fixed.
> > Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org> > > Thanks a lot for the patch! > > Reviewed-by: Nathan Chancellor <nathan@kernel.org> > > I don't know if those nits are worth resending but I do not see this > applied to Mark's tree yet. It might have gotten lost because this was > sent as a reply to the build report, rather than its own thread, which > has caused issues for me in the past: > > https://lore.kernel.org/r/20210903162639.GM4932@sirena.org.uk/ > > If there is no action on this patch in the next couple of days, please > consider resending with the above nits addressed with Codrin's tag and > my tag.
Will address those. Thanks for the review.
-- Viro
| |