Messages in this thread | | | Date | Mon, 14 Mar 2022 15:07:41 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net v3] net: phy: marvell: Fix invalid comparison in the resume and suspend functions |
| |
On Sat, 12 Mar 2022 15:15:13 -0500 Kurt Cancemi wrote: > - if (!linkmode_test_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, > + if (linkmode_test_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, > phydev->supported)) {
You should align the continuation lines so that the start matches the opening parenthesis. I'll fix it up when applying for you this time but please make sure to run checkpatch.pl --strict on patches before submission. Thanks!
| |