Messages in this thread | | | From | Frank Wunderlich <> | Subject | Aw: Re: [PATCH v6 3/6] ARM: dts: spear13xx: Fix sata node name | Date | Mon, 14 Mar 2022 16:38:56 +0100 |
| |
Hi,
thanks for for checking the spear-patch.
> Gesendet: Montag, 14. März 2022 um 04:49 Uhr > Von: "Viresh Kumar" <viresh.kumar@linaro.org> > > On 11-03-22, 22:03, Frank Wunderlich wrote: > > From: Frank Wunderlich <frank-w@public-files.de> > > > > After converting the binding to yaml the node name does > > not match the standard pattern, change it. > > > > arch/arm/boot/dts/spear1340-evb.dt.yaml: ahci@b1000000: > > $nodename:0: 'ahci@b1000000' does not match '^sata(@.*)?$' > > From schema: Documentation/devicetree/bindings/ata/ahci-platform.yaml > > > > Fixes: 07658d9a659b ("SPEAr13xx: Add dts and dtsi files") > > I don't think this is correct. The above patch is correct. The first > patch in this series changes the names and that's where things break.
it's right that my binding will break it, but the nodes are not named the right way. And i used the commit that introduces the wrong node-names. Maybe fixes-tag is wrong in this case.
> I think you could have added these patches before changing to yaml and > then nothing would ever have broken. > > Since this isn't a big deal anyway, I think you can just drop the > Fixes tag here, and other dts patches you have.
regards Frank
| |