Messages in this thread | | | Date | Mon, 14 Mar 2022 09:05:06 -0600 | Subject | Re: [PATCH] sr: simplify the local variable initialization in sr_block_open() | From | Jens Axboe <> |
| |
On 3/14/22 9:03 AM, Lukas Bulwahn wrote: > Commit 01d0c698536f ("sr: implement ->free_disk to simplify refcounting") > refactored sr_block_open(), initialized one variable with a duplicate > assignment (probably an unintended copy & paste duplication) and turned one > error case into an early return, which makes the initialization of the > return variable needless. > > So, simplify the local variable initialization in sr_block_open() to make > the code a bit more clear. > > No functional change. No change in resulting object code. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > Christoph, please ack. > > Jens, please pick this minor clean-up on your -next branch on top of the > commit above.
Should it have a Fixes line?
-- Jens Axboe
| |