lkml.org 
[lkml]   [2022]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/3] mm/memory-failure.c: avoid calling invalidate_inode_page() with unexpected pages
    Date
    Since commit 042c4f32323b ("mm/truncate: Inline invalidate_complete_page()
    into its one caller"), invalidate_inode_page() can invalidate the pages in
    the swap cache because the check of page->mapping != mapping is removed.
    But invalidate_inode_page() is not expected to deal with the pages in swap
    cache. Also non-lru movable page can reach here too. They're not page cache
    pages. Skip these pages by checking PageSwapCache and PageLRU.

    Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
    ---
    mm/memory-failure.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/mm/memory-failure.c b/mm/memory-failure.c
    index dabecd87ad3f..2ff7dd2078c4 100644
    --- a/mm/memory-failure.c
    +++ b/mm/memory-failure.c
    @@ -2190,7 +2190,7 @@ static int __soft_offline_page(struct page *page)
    return 0;
    }

    - if (!PageHuge(page))
    + if (!PageHuge(page) && PageLRU(page) && !PageSwapCache(page))
    /*
    * Try to invalidate first. This should work for
    * non dirty unmapped page cache pages.
    --
    2.23.0
    \
     
     \ /
      Last update: 2022-03-12 08:48    [W:3.005 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site