| Date | Sun, 13 Mar 2022 00:10:48 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 14/19] rcu/context-tracking: Move RCU-dynticks internal functions to context_tracking |
| |
On Wed, Mar 02, 2022 at 04:48:05PM +0100, Frederic Weisbecker wrote: > +noinstr unsigned long rcu_dynticks_inc(int incby) > +{ > + return arch_atomic_add_return(incby, this_cpu_ptr(&context_tracking.dynticks)); > +}
noinstr implies noinline, making the above a rather sad little function; would it perhaps be better to make it __always_inline ?
Also; I could imagine myself doing an arch special for this such that x86 generates:
LOCK XADD [reg], %gs:[var]
But that's for later I suppose, it would be but a little tweak to perpcu_add_return_op()
|