lkml.org 
[lkml]   [2022]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH V2] net: mv643xx_eth: use platform_get_irq() instead of platform_get_resource()
On Thu, 10 Mar 2022 06:20:35 +0000 cgel.zte@gmail.com wrote:
> @@ -3189,9 +3188,10 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
> timer_setup(&mp->rx_oom, oom_timer_wrapper, 0);
>
>
> - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - BUG_ON(!res);
> - dev->irq = res->start;
> + irq = platform_get_irq(pdev, 0);
> + if (WARN_ON(irq < 0))
> + return irq;

You can't just return from here, there are operations that need
to be undone, look at the end of this function :/ Please follow
up with an incremental fix ASAP.

> + dev->irq = irq;
>

\
 
 \ /
  Last update: 2022-03-11 17:22    [W:0.080 / U:4.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site