Messages in this thread | | | Date | Fri, 11 Mar 2022 09:29:16 +0800 | From | Mingbao Sun <> | Subject | Re: [PATCH] tcp: export symbol tcp_set_congestion_control |
| |
On Thu, 10 Mar 2022 12:48:25 -0800 Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 10 Mar 2022 21:48:30 +0800 Mingbao Sun wrote: > > Since the kernel API 'kernel_setsockopt' was removed, and since the > > function ‘tcp_set_congestion_control’ is just the real underlying guy > > handling this job, so it makes sense to get it exported. > > Do you happen to have a reference to the commit which removed > kernel_setsockopt and the justification? My knee jerk reaction > would the that's a better path than allowing in-kernel socket users > to poke at internal functions even if that works as of today.
FYI (Sorry for putting URLs in the mail):
kernel_setsockopt disappeared from kernel v5.8, and all the relevant users have switched to dedicated small functions.
The mail thread: https://lists.archive.carbon60.com/linux/kernel/3712394
The commit: https://github.com/torvalds/linux/commit/5a892ff2facb4548c17c05931ed899038a0da63e
| |