Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 10 Mar 2022 09:19:54 +0100 | Subject | Re: [PATCH] tty: serial: bcm63xx: use more precise Kconfig symbol |
| |
Hi Rafał,
On Thu, Mar 10, 2022 at 8:22 AM Rafał Miłecki <zajec5@gmail.com> wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Patches lowering SERIAL_BCM63XX dependencies led to a discussion and > documentation change regarding "depends" usage. Adjust Kconfig entry to > match current guidelines. Make this symbol available for relevant > architectures only. > > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Ref: f35a07f92616 ("tty: serial: bcm63xx: lower driver dependencies") > Ref: 18084e435ff6 ("Documentation/kbuild: Document platform dependency practises") > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Thanks for your patch!
> --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1100,7 +1100,8 @@ config SERIAL_TIMBERDALE > config SERIAL_BCM63XX > tristate "Broadcom BCM63xx/BCM33xx UART support" > select SERIAL_CORE > - depends on COMMON_CLK > + depends on MIPS || ARM || ARM64 || COMPILE_TEST > + default ARCH_BCM4908 || BCM63XX || BMIPS_GENERIC
So ARCH_BCM4908 covers ARM64, and BCM63XX || BMIPS_GENERIC cover MIPS. Is there some symbol covering ARM so we can change the depends to
depends on FOO || ARCH_BCM4908 || BCM63XX || BMIPS_GENERIC || COMPILE_TEST
?
Anyway, this is definitely a step in the good direction!
> help > This enables the driver for the onchip UART core found on > the following chipsets:
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |