Messages in this thread | | | From | Peter Robinson <> | Date | Thu, 10 Mar 2022 17:30:31 +0000 | Subject | Re: [PATCH] net: bcmgenet: Don't claim WOL when its not available |
| |
On Thu, Mar 10, 2022 at 4:55 AM Jeremy Linton <jeremy.linton@arm.com> wrote: > > Some of the bcmgenet platforms don't correctly support WOL, yet > ethtool returns: > > "Supports Wake-on: gsf" > > which is false. > > Ideally if there isn't a wol_irq, or there is something else that > keeps the device from being able to wakeup it should display: > > "Supports Wake-on: d" > > This patch checks whether the device can wakup, before using the > hard-coded supported flags. This corrects the ethtool reporting, as > well as the WOL configuration because ethtool verifies that the mode > is supported before attempting it. > > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com> Tested-by: Peter Robinson <pbrobinson@gmail.com>
This fixes the reporting of the WOL capabilities on the Raspberry Pi 4.
> --- > drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c b/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c > index e31a5a397f11..f55d9d9c01a8 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c > @@ -40,6 +40,13 @@ > void bcmgenet_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol) > { > struct bcmgenet_priv *priv = netdev_priv(dev); > + struct device *kdev = &priv->pdev->dev; > + > + if (!device_can_wakeup(kdev)) { > + wol->supported = 0; > + wol->wolopts = 0; > + return; > + } > > wol->supported = WAKE_MAGIC | WAKE_MAGICSECURE | WAKE_FILTER; > wol->wolopts = priv->wolopts; > -- > 2.35.1 >
| |