Messages in this thread Patch in this message | | | Date | Tue, 01 Mar 2022 18:27:54 -0000 | From | "irqchip-bot for Souptick Joarder (HPE)" <> | Subject | [irqchip: irq/irqchip-next] irqchip/nvic: Release nvic_base upon failure |
| |
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: e414c25e3399b2b3d7337dc47abccab5c71b7c8f Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/e414c25e3399b2b3d7337dc47abccab5c71b7c8f Author: Souptick Joarder (HPE) <jrdr.linux@gmail.com> AuthorDate: Fri, 18 Feb 2022 22:03:03 +05:30 Committer: Marc Zyngier <maz@kernel.org> CommitterDate: Tue, 01 Mar 2022 10:19:51
irqchip/nvic: Release nvic_base upon failure
smatch warning was reported as below ->
smatch warnings: drivers/irqchip/irq-nvic.c:131 nvic_of_init() warn: 'nvic_base' not released on lines: 97.
Release nvic_base upon failure.
Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220218163303.33344-1-jrdr.linux@gmail.com --- drivers/irqchip/irq-nvic.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c index ba4759b..9423030 100644 --- a/drivers/irqchip/irq-nvic.c +++ b/drivers/irqchip/irq-nvic.c @@ -107,6 +107,7 @@ static int __init nvic_of_init(struct device_node *node, if (!nvic_irq_domain) { pr_warn("Failed to allocate irq domain\n"); + iounmap(nvic_base); return -ENOMEM; } @@ -116,6 +117,7 @@ static int __init nvic_of_init(struct device_node *node, if (ret) { pr_warn("Failed to allocate irq chips\n"); irq_domain_remove(nvic_irq_domain); + iounmap(nvic_base); return ret; }
| |