Messages in this thread | | | Date | Tue, 1 Mar 2022 10:15:25 -0800 | From | Ira Weiny <> | Subject | Re: [PATCH V8 37/44] memremap_pages: Set PKS PKey in PTEs if PGMAP_PROTECTIONS is requested |
| |
On Fri, Feb 04, 2022 at 09:41:59AM -0800, Dan Williams wrote: > On Thu, Jan 27, 2022 at 9:55 AM <ira.weiny@intel.com> wrote: > > > > From: Ira Weiny <ira.weiny@intel.com> > > > > When the user requests protections the dev_pagemap mappings need to have > > a PKEY set. > > > > Define devmap_protection_adjust_pgprot() to add the PKey to the page > > protections. Call it when PGMAP_PROTECTIONS is requested when remapping > > pages. > > > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > --- > > Does this patch have a reason to exist independent of the patch that > introduced devmap_protection_enable()? > > Otherwise looks ok.
Just easier to review this specific change. For V8 I split the patches up quite a bit to be much more direct to 1 change/patch. I think it worked out well and I don't plan to merge much in V9 because as you say this change looks good. :-D
Ira
| |