Messages in this thread | | | From | <> | Subject | Re: [PATCH v2] media: atmel: atmel-isc: Fix PM disable depth imbalance in atmel_isc_probe | Date | Tue, 1 Mar 2022 13:51:02 +0000 |
| |
On 3/1/22 9:18 AM, Miaoqian Lin wrote: > The pm_runtime_enable will increase power disable depth. > If the probe fails, we should use pm_runtime_disable() to balance > pm_runtime_enable(). > > Fixes: 0a0e265 ("media: atmel: atmel-isc: split driver into driver base and isc") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > changes in v2: > - remove unused label. > --- > drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c > index 1b2063cce0f7..7f1ebbb25437 100644 > --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c > +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c > @@ -559,6 +559,8 @@ static int atmel_isc_probe(struct platform_device *pdev) > cleanup_subdev: > isc_subdev_cleanup(isc); > > + pm_runtime_disable(dev); > +
Hello Miaoqian Lin ,
Could you please perform the same change (or similar) in atmel-sama7g5-isc , as the sama7g5 ISC will perform the same and has the same bug.
Thank you for the patch, Eugen
> unregister_v4l2_device: > v4l2_device_unregister(&isc->v4l2_dev); > > -- > 2.17.1 >
| |