lkml.org 
[lkml]   [2022]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: fsi: Add check for clk_enable
On Tue, Mar 01, 2022 at 03:39:49PM +0800, Jiasheng Jiang wrote:
> As the potential failure of the clk_enable(),
> it should be better to check it and return error
> if fails.

> - clk_enable(clock->xck);
> - clk_enable(clock->ick);
> - clk_enable(clock->div);
> + ret = clk_enable(clock->xck);
> + if (ret)
> + goto err;
> + ret = clk_enable(clock->ick);
> + if (ret)
> + goto err;
> + ret = clk_enable(clock->div);
> + if (ret)
> + goto err;
>
> clock->count++;
> }
>
> return ret;
> +
> +err:
> + clk_disable(clock->xck);
> + clk_disable(clock->ick);
> + clk_disable(clock->div);

You need separate labels for each enable so that we don't end up
disabling clocks we didn't enable, that would also be a bug.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-03-01 13:44    [W:0.059 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site