lkml.org 
[lkml]   [2022]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net/nfc/nci: use memset avoid infoleaks
From
On 01/03/2022 10:34, Lv Ruyi wrote:
> hello sir
>
> I think this way: On 64-bit systems, struct nci_set_config_param has
> an added padding of 7 bytes between struct members id and len. Even
> though all struct members are initialized, the 7-byte hole will
> contain data from the kernel stack.
>

That's reasonable. This explanation should be mentioned in the commit
msg. Also just initialize the array to 0, instead of separate memset call.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-03-01 11:25    [W:0.067 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site