lkml.org 
[lkml]   [2022]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/8] sched: coredump.h: clarify the use of MMF_VM_HUGEPAGE
From
Date
On 2022/3/1 7:57, Yang Shi wrote:
> MMF_VM_HUGEPAGE is set as long as the mm is available for khugepaged by
> khugepaged_enter(), not only when VM_HUGEPAGE is set on vma. Correct
> the comment to avoid confusion.
>
> Signed-off-by: Yang Shi <shy828301@gmail.com>
> ---
> include/linux/sched/coredump.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h
> index 4d9e3a656875..4d0a5be28b70 100644
> --- a/include/linux/sched/coredump.h
> +++ b/include/linux/sched/coredump.h
> @@ -57,7 +57,8 @@ static inline int get_dumpable(struct mm_struct *mm)
> #endif
> /* leave room for more dump flags */
> #define MMF_VM_MERGEABLE 16 /* KSM may merge identical pages */
> -#define MMF_VM_HUGEPAGE 17 /* set when VM_HUGEPAGE is set on vma */
> +#define MMF_VM_HUGEPAGE 17 /* set when mm is available for
> + khugepaged */

I think this comment could be written in one line. Anyway, this patch looks good to me.
Thanks.

Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>

> /*
> * This one-shot flag is dropped due to necessity of changing exe once again
> * on NFS restore
>

\
 
 \ /
  Last update: 2022-03-01 09:46    [W:0.118 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site