lkml.org 
[lkml]   [2022]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] ASoC: fsi: Add check for clk_enable
Date

Hi Jiasheng

Thank you for your patch

> As the potential failure of the clk_enable(),
> it should be better to check it and return error
> if fails.
>
> Fixes: ab6f6d85210c ("ASoC: fsi: add master clock control functions")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
(snip)
> + if (ret)
> + goto err;
> + ret = clk_enable(clock->ick);
> + if (ret)
> + goto disable_xck;
> + ret = clk_enable(clock->div);
> + if (ret)
> + goto disable_ick;
>
> clock->count++;
> }
>
> return ret;
> +
> +disable_xck:
> + clk_disable(clock->xck);
> +disable_ick:
> + clk_disable(clock->ick);
> +err:
> + return ret;
> }

I think disable_ick() / disable_xck() order are inverted ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto

\
 
 \ /
  Last update: 2022-03-02 05:35    [W:0.031 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site