lkml.org 
[lkml]   [2022]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v13 2/2] leds: Add driver for Qualcomm LPG
On Thu 24 Feb 08:59 PST 2022, Uwe Kleine-K?nig wrote:
> On Fri, Feb 18, 2022 at 10:31:16AM -0800, Bjorn Andersson wrote:
[..]
> > diff --git a/Documentation/leds/leds-qcom-lpg.rst b/Documentation/leds/leds-qcom-lpg.rst
[..]
> > +Simple pattern::
> > +
> > + "255 500 0 500"
> > +
> > + ^
> > + |
> > + 255 +----+ +----+
> > + | | | | ...
> > + 0 | +----+ +----
> > + +---------------------->
> > + 0 5 10 15 time (100ms)
>
> you're mixing tabs and spaces here, I suggest to use spaces only. Not
> sure you want to respin for that.
>
> (I didn't look into the rest of the driver, but assume it's fine.)
>

Pavel, would yo like me to fix this up and send out v14 or would you be
okay replacing the tab with spaces while applying the patches?

Do you see any other blockers for merging this?

Thanks,
Bjorn

\
 
 \ /
  Last update: 2022-03-02 00:23    [W:0.212 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site