Messages in this thread | | | Date | Tue, 1 Mar 2022 23:24:40 +0100 | From | Marijn Suijten <> | Subject | Re: [PATCH] arm64: dts: qcom: Drop bogus interrupt flags cell on MDSS nodes |
| |
Hi Rob,
On 2022-03-01 15:05:31, Rob Herring wrote: > The MDSS interrupt provider is a single cell, so specifying interrupt flags > on the consumers is incorrect.
There seem to be many more violators of `#interrupt-cells = <1>;`, at least on -next e6ada6df471f. It seems those are not intentionally omitted in this patch? Searching for `interrupt-parent = <&mdss>;` globally and evaluating `interrupts =` right next to it yields:
- Two more hits in both sdm845.dtsi and sm8250.dtsi; - qcom-msm8974.dtsi; - msm8996.dtsi; - sdm630.dtsi; - sdm660.dtsi.
And for the docs patch: - mdp5.txt; - And the recently added dpu-qcm2290.yaml, whose CI failure might have exactly lead to this patch?
Would you mind cleaning these up in a v2, or otherwise explain and forgive my ignorance for not seeing why these were not changed?
Thanks!
- Marijn
> Signed-off-by: Rob Herring <robh@kernel.org> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 41f4e46e1f85..a6bf04780667 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -4281,7 +4281,7 @@ mdss_mdp: mdp@ae01000 { > power-domains = <&rpmhpd SDM845_CX>; > > interrupt-parent = <&mdss>; > - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <0>; > > ports { > #address-cells = <1>; > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index fdaf303ba047..e732e3370c75 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -3200,7 +3200,7 @@ mdss_mdp: mdp@ae01000 { > power-domains = <&rpmhpd SM8250_MMCX>; > > interrupt-parent = <&mdss>; > - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <0>; > > ports { > #address-cells = <1>; > -- > 2.32.0 >
| |