Messages in this thread | | | Date | Wed, 9 Feb 2022 17:04:36 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] spi: initialize ret variable |
| |
On Wed, Feb 09, 2022 at 08:44:21AM -0800, Tom Rix wrote: > On 2/9/22 8:33 AM, Mark Brown wrote: > > On Wed, Feb 09, 2022 at 08:30:29AM -0800, trix@redhat.com wrote:
> > > Clang build fails with > > > spi-sunplus-sp7021.c:405:2: error: variable 'ret' is used > > > uninitialized whenever switch default is taken > > > default: > > > ^~~~~~~
> > > Restore initializing ret.
> > Are you sure this is a good fix and that the compiler hasn't instead > > identifed that we should be returning an error in the default case?
> If setting mode to idle is not really a valid state, then default should > return an error.
Yes, that's what I'm asking.
> The old behavior returned 0 and I am treating this as a regression.
The goal here isn't just to shut up warnings, it's to fix any problems that they identify. Unconditionally initialising return values is a common way of fixing warnings while leaving real problems in place. [unhandled content-type:application/pgp-signature] | |