Messages in this thread | | | Date | Wed, 9 Feb 2022 14:37:56 +0000 | From | Aaron Tomlin <> | Subject | Re: [RFC PATCH v4 07/13] module: Move extra signature support out of core code |
| |
On Wed 2022-02-09 15:28 +0100, Miroslav Benes wrote: > Please, drop these extern modifiers in front of function declarations. > They are unnecessary. It applies to different patches of the set as well.
Agreed - this was suggested previously. The next iteration should be published soon. Just waiting on 0-day.
> > +#ifdef CONFIG_MODULE_SIG > > +extern int module_sig_check(struct load_info *info, int flags); > > +#else /* !CONFIG_MODULE_SIG */ > > +static int module_sig_check(struct load_info *info, int flags) > > +{ > > + return 0; > > +} > > I think it should be > static inline int module_sig_check(struct load_info *info, int flags)
Yes, indeed it should. Thanks for the feedback.
Kind regards,
-- Aaron Tomlin
| |