Messages in this thread | | | Date | Wed, 9 Feb 2022 18:31:47 -0600 | From | Rob Herring <> | Subject | Re: [PATCH] dt-bindings: pinctrl: mt8195: fix bias-pull-{up,down} checks |
| |
On Wed, 02 Feb 2022 23:35:28 +0800, Chen-Yu Tsai wrote: > When the constraints and description for bias-pull-{up,down} were added, > the constraints were not indented correctly, resulting in them being > parsed as part of the description. This effectively nullified their > purpose. > > Move the constraints out of the description block, make each description > part of the same associative array as the enum its describing, and > reindent them correctly so they take effect. > > Also add "type: boolean" to the list of valid values. This corresponds > to having bias-pull-{up,down} without any arguments. > > Fixes: 91e7edceda96 ("dt-bindings: pinctrl: mt8195: change pull up/down description") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > .../bindings/pinctrl/pinctrl-mt8195.yaml | 30 ++++++++++--------- > 1 file changed, 16 insertions(+), 14 deletions(-) >
Reviewed-by: Rob Herring <robh@kernel.org>
| |