Messages in this thread | | | Date | Wed, 9 Feb 2022 20:47:39 +0000 | From | Giovanni Cabiddu <> | Subject | Re: [PATCH v1 1/1] crypto: qat - don't cast parameter in bit operations |
| |
Thanks Andy.
On Wed, Feb 09, 2022 at 08:00:47PM +0200, Andy Shevchenko wrote: > While in this particular case it would not be a (critical) issue, > the pattern itself is bad and error prone in case the location > of the parameter is changed. > > Don't cast parameter to unsigned long pointer in the bit operations. > Instead copy to a local variable on stack of a proper type and use. > > Fixes: b4b7e67c917f ("crypto: qat - Intel(R) QAT ucode part of fw loader") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
-- Giovanni
| |