Messages in this thread | | | Date | Wed, 9 Feb 2022 19:56:42 +0100 | From | Dominik Brodowski <> | Subject | Re: [PATCH v2] random: make more consistent use of integer types |
| |
Am Wed, Feb 09, 2022 at 07:05:07PM +0100 schrieb Jason A. Donenfeld: > We've been using a flurry of int, unsigned int, size_t, and ssize_t. > Let's unify all of this into size_t where it makes sense, as it does in > most places, and leave ssize_t for return values with possible errors. > > In addition, keeping with the convention of other functions in this > file, functions that are dealing with raw bytes now take void * > consistently instead of a mix of that and u8 *, because much of the time > we're actually passing some other structure that is then interpreted as > bytes by the function. > > We also take the opportunity to fix the outdated and incorrect comment > in get_random_bytes_arch(). > > Cc: Theodore Ts'o <tytso@mit.edu> > Cc: Dominik Brodowski <linux@dominikbrodowski.net> > Reviewed-by: Jann Horn <jannh@google.com> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Thanks, Dominik
| |