Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 8 Feb 2022 22:10:19 +0200 | Subject | Re: [PATCH v4 9/9] i2c: piix4: Enable EFCH MMIO for Family 17h+ |
| |
On Tue, Feb 8, 2022 at 6:33 PM Jean Delvare <jdelvare@suse.de> wrote: > On Sun, 30 Jan 2022 12:41:30 -0600, Terry Bowman wrote:
...
> > +#define AMD_PCI_SMBUS_REVISION_MMIO 0x51 > > I don't think that was worth a define. You only use the value once, in > a context where the symbolic name doesn't add much value IMHO.
I don't remember the code context here, but it would be nice in such a case to convert this definition to a comment (if it's not crystal clear what this magic number is about).
-- With Best Regards, Andy Shevchenko
| |