Messages in this thread | | | From | Stephen Boyd <> | Date | Tue, 8 Feb 2022 13:12:54 -0800 | Subject | Re: [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add wcd9380 pinmux |
| |
Quoting Srinivasa Rao Mandadapu (2022-02-08 07:34:14) > Add pinmux to reset wcd codec, conneceted on SC7280 based platforms. > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> > Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 4704a93..6b38fa1 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -594,6 +594,21 @@ > */ > bias-pull-up; > }; > + > + wcd938x_reset_active: wcd938x_reset_active {
No underscore in node names.
> + pins = "gpio83"; > + function = "gpio"; > + drive-strength = <16>; > + output-high; > + }; > + > + wcd938x_reset_sleep: wcd938x_reset_sleep { > + pins = "gpio83"; > + function = "gpio"; > + drive-strength = <16>; > + bias-disable; > + output-low;
Why doesn't the device drive the reset gpio by requesting the gpio and asserting and deasserting it? We shouldn't need to use pinctrl settings to toggle reset gpios.
| |