Messages in this thread | | | From | Namhyung Kim <> | Date | Tue, 8 Feb 2022 11:16:46 -0800 | Subject | Re: [PATCH 02/12] cgroup: rstat: Make cgroup_rstat_cpu_lock name readable |
| |
Hi Tejun,
On Tue, Feb 8, 2022 at 10:46 AM Tejun Heo <tj@kernel.org> wrote: > > On Tue, Feb 08, 2022 at 10:41:58AM -0800, Namhyung Kim wrote: > > The raw_spin_lock_init() uses the argument to name its lockdep map. > > But passing per_cpu_ptr() macro directly makes it a very very long > > name as it expanded like below: > > > > ({ do { const void *__vpp_verify = (typeof((&cgroup_rstat_cpu_lock) ... > > > > Let's fix it by passing a local variable instead. With this change, > > the name now looks like: > > > > cgrp_rstat_cpu_lock > > > > Cc: Tejun Heo <tj@kernel.org> > > Cc: Zefan Li <lizefan.x@bytedance.com> > > Cc: Johannes Weiner <hannes@cmpxchg.org> > > Cc: cgroups@vger.kernel.org > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > Acked-by: Tejun Heo <tj@kernel.org>
Thanks!
> > but maybe add a comment explaining what's going on?
Sure, I'll add the comment.
| |