Messages in this thread | | | From | "Alim Akhtar" <> | Subject | RE: [PATCH v3 5/8] dt-bindings: memory: lpddr3: deprecate manufacturer ID | Date | Mon, 7 Feb 2022 09:44:25 +0530 |
| |
Hi Krzysztof
>-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Sunday, February 6, 2022 7:28 PM >To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; Rob Herring ><robh+dt@kernel.org>; Lukasz Luba <lukasz.luba@arm.com>; Alim Akhtar ><alim.akhtar@samsung.com>; Dmitry Osipenko <digetx@gmail.com>; linux- >kernel@vger.kernel.org; devicetree@vger.kernel.org; linux- >pm@vger.kernel.org; linux-samsung-soc@vger.kernel.org; linux-arm- >kernel@lists.infradead.org >Subject: [PATCH v3 5/8] dt-bindings: memory: lpddr3: deprecate >manufacturer ID > >The memory manufacturer should be described in vendor part of compatible, >so there is no need to duplicate it in a separate property. >Similarly is done in LPDDR2 bindings. > >Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >--- > .../bindings/memory-controllers/ddr/jedec,lpddr3.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/Documentation/devicetree/bindings/memory- >controllers/ddr/jedec,lpddr3.yaml >b/Documentation/devicetree/bindings/memory- >controllers/ddr/jedec,lpddr3.yaml >index d6787b5190ee..3bcba15098ea 100644 >--- a/Documentation/devicetree/bindings/memory- >controllers/ddr/jedec,lpddr3.yaml >+++ b/Documentation/devicetree/bindings/memory- >controllers/ddr/jedec,lpd >+++ dr3.yaml >@@ -40,7 +40,9 @@ properties: > manufacturer-id: > $ref: /schemas/types.yaml#/definitions/uint32 > description: | >- Manufacturer ID value read from Mode Register 5. >+ Manufacturer ID value read from Mode Register 5. The property is >+ deprecated, manufacturer should be derived from the compatible. >+ deprecated: true >
Shouldn't it be the other way? As DT describes hardware and MR5 does contain the Manufacturer ID, so getting Manufacturer ID from MR5 makes aligned to hardware description.
> revision-id: > $ref: /schemas/types.yaml#/definitions/uint32-array >-- >2.32.0
| |