Messages in this thread | | | Date | Mon, 7 Feb 2022 12:12:47 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of __add_pages |
| |
On Mon, 7 Feb 2022 15:41:21 +0100 David Hildenbrand <david@redhat.com> wrote:
> On 07.02.22 14:36, Miaohe Lin wrote: > > Since commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > > memory to zones until online"), there is no need to pass in the zone. > > > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > > --- > > mm/memory_hotplug.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index a4f69d399929..cbc67c27e0dd 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -296,10 +296,7 @@ struct page *pfn_to_online_page(unsigned long pfn) > > EXPORT_SYMBOL_GPL(pfn_to_online_page); > > > > /* > > - * Reasonably generic function for adding memory. It is > > - * expected that archs that support memory hotplug will > > - * call this function after deciding the zone to which to > > - * add the new pages. > > + * Reasonably generic function for adding memory. > > */ > > int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, > > struct mhp_params *params) > > I'd suggest just removing the comment completely.
Thanks, I made that change.
A better site for documentation is at add_memory(). Which, as a full-on exported-to-modules API function, should really have some docs...
| |