lkml.org 
[lkml]   [2022]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 28/42] tools/nolibc/string: use unidirectional variants for memcpy()
    Date
    Till now memcpy() relies on memmove(), but it's always included for libgcc,
    so we have a larger than needed function. Let's implement two unidirectional
    variants to copy from bottom to top and from top to bottom, and use the
    former for memcpy(). The variants are optimized to be compact, and at the
    same time the compiler is sometimes able to detect the loop and to replace
    it with a "rep movsb". The new function is 24 bytes instead of 52 on x86_64.

    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    tools/include/nolibc/string.h | 24 +++++++++++++++++++++++-
    1 file changed, 23 insertions(+), 1 deletion(-)

    diff --git a/tools/include/nolibc/string.h b/tools/include/nolibc/string.h
    index 8a23cda2d450..6d8fad7a92e6 100644
    --- a/tools/include/nolibc/string.h
    +++ b/tools/include/nolibc/string.h
    @@ -25,6 +25,28 @@ int memcmp(const void *s1, const void *s2, size_t n)
    return c1;
    }

    +static __attribute__((unused))
    +void *_nolibc_memcpy_up(void *dst, const void *src, size_t len)
    +{
    + size_t pos = 0;
    +
    + while (pos < len) {
    + ((char *)dst)[pos] = ((const char *)src)[pos];
    + pos++;
    + }
    + return dst;
    +}
    +
    +static __attribute__((unused))
    +void *_nolibc_memcpy_down(void *dst, const void *src, size_t len)
    +{
    + while (len) {
    + len--;
    + ((char *)dst)[len] = ((const char *)src)[len];
    + }
    + return dst;
    +}
    +
    static __attribute__((unused))
    void *memmove(void *dst, const void *src, size_t len)
    {
    @@ -42,7 +64,7 @@ void *memmove(void *dst, const void *src, size_t len)
    __attribute__((weak,unused))
    void *memcpy(void *dst, const void *src, size_t len)
    {
    - return memmove(dst, src, len);
    + return _nolibc_memcpy_up(dst, src, len);
    }

    static __attribute__((unused))
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-02-07 17:39    [W:4.069 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site