| Date | Thu, 3 Feb 2022 22:30:16 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH 09/21] fbcon: Replace FBCON_FLAGS_INIT with a boolean |
| |
On Mon, Jan 31, 2022 at 10:05:40PM +0100, Daniel Vetter wrote: > It's only one flag and slightly tidier code. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Du Cheng <ducheng2@gmail.com> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Claudio Suarez <cssk@net-c.es> Acked-by: Sam Ravnborg <sam@ravnborg.org>
Next step is to convert some of the int flags to bool - so it is obvious this is bool and not an int. I do not like bitfields for bools when there is no big win in memory usage - so not fan of that suggestion.
Sam
|