Messages in this thread | | | Date | Sat, 5 Feb 2022 15:57:49 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: phy: mscc: enable MAC SerDes autonegotiation |
| |
On Sat, Feb 05, 2022 at 12:14:52PM +0530, Raag Jadav wrote: > Enable MAC SerDes autonegotiation to distinguish between > 1000BASE-X, SGMII and QSGMII MAC.
How does autoneg help you here? It just tells you about duplex, pause etc. It does not indicate 1000BaseX, SGMII etc. The PHY should be using whatever mode it was passed in phydev->interface, which the MAC sets when it calls the connection function. If the PHY dynamically changes its host side mode as a result of what that line side is doing, it should also change phydev->interface. However, as far as i can see, the mscc does not do this.
So i don't understand this commit message.
Andrew
| |