lkml.org 
[lkml]   [2022]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] livepatch: Skip livepatch tests if ftrace cannot be configured
On Fri, Feb 04, 2022 at 03:30:02PM -0500, Joe Lawrence wrote:

Hi Joe,

Thanks for the review.

> sp: s/permament/permanent
>

Ack, thanks for catching that.

> > + if [[ "$result" == *"Device or resource busy"* ]]; then
> > + skip "failed to set kernel.ftrace_enabled=$1"
> > + fi
> > +
>
> style nit: move the blank line from here to just before the new # Skip
> comment

Ack.

> Can we be more paranoid and just look for the exact result that we expect:
>
> if [[ "$result" != "kernel.ftrace_enabled = 1" ]]; then
> skip "failed to set kernel.ftrace_enabled=$1"
> fi

Agreed, this is cleaner and less brittle.

I'll follow-up with a v2 patch shortly. Thanks!

- David

\
 
 \ /
  Last update: 2022-02-04 21:44    [W:0.140 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site