lkml.org 
[lkml]   [2022]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 36/41] usb: dwc2: gadget: don't try to disable ep0 in dwc2_hsotg_suspend
    Date
    From: Amelie Delaunay <amelie.delaunay@foss.st.com>

    [ Upstream commit ac55d163855924aa5af9f1560977da8f346963c8 ]

    Calling dwc2_hsotg_ep_disable on ep0 (in/out) will lead to the following
    logs before returning -EINVAL:
    dwc2 49000000.usb-otg: dwc2_hsotg_ep_disable: called for ep0
    dwc2 49000000.usb-otg: dwc2_hsotg_ep_disable: called for ep0

    To avoid these two logs while suspending, start disabling the endpoint
    from the index 1, as done in dwc2_hsotg_udc_stop:

    /* all endpoints should be shutdown */
    for (ep = 1; ep < hsotg->num_of_eps; ep++) {
    if (hsotg->eps_in[ep])
    dwc2_hsotg_ep_disable_lock(&hsotg->eps_in[ep]->ep);
    if (hsotg->eps_out[ep])
    dwc2_hsotg_ep_disable_lock(&hsotg->eps_out[ep]->ep);
    }

    Acked-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
    Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
    Link: https://lore.kernel.org/r/20211207130101.270314-1-amelie.delaunay@foss.st.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/dwc2/gadget.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
    index ea0d2d6139a68..0909b088a284b 100644
    --- a/drivers/usb/dwc2/gadget.c
    +++ b/drivers/usb/dwc2/gadget.c
    @@ -5096,7 +5096,7 @@ int dwc2_hsotg_suspend(struct dwc2_hsotg *hsotg)
    hsotg->gadget.speed = USB_SPEED_UNKNOWN;
    spin_unlock_irqrestore(&hsotg->lock, flags);

    - for (ep = 0; ep < hsotg->num_of_eps; ep++) {
    + for (ep = 1; ep < hsotg->num_of_eps; ep++) {
    if (hsotg->eps_in[ep])
    dwc2_hsotg_ep_disable_lock(&hsotg->eps_in[ep]->ep);
    if (hsotg->eps_out[ep])
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-02-03 21:39    [W:3.229 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site