lkml.org 
[lkml]   [2022]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.16 26/52] scsi: target: iscsi: Make sure the np under each tpg is unique
    Date
    From: ZouMingzhe <mingzhe.zou@easystack.cn>

    [ Upstream commit a861790afaa8b6369eee8a88c5d5d73f5799c0c6 ]

    iscsit_tpg_check_network_portal() has nested for_each loops and is supposed
    to return true when a match is found. However, the tpg loop will still
    continue after existing the tpg_np loop. If this tpg_np is not the last the
    match value will be changed.

    Break the outer loop after finding a match and make sure the np under each
    tpg is unique.

    Link: https://lore.kernel.org/r/20220111054742.19582-1-mingzhe.zou@easystack.cn
    Signed-off-by: ZouMingzhe <mingzhe.zou@easystack.cn>
    Reviewed-by: Mike Christie <michael.christie@oracle.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/target/iscsi/iscsi_target_tpg.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/target/iscsi/iscsi_target_tpg.c b/drivers/target/iscsi/iscsi_target_tpg.c
    index 8075f60fd02c3..2d5cf1714ae05 100644
    --- a/drivers/target/iscsi/iscsi_target_tpg.c
    +++ b/drivers/target/iscsi/iscsi_target_tpg.c
    @@ -443,6 +443,9 @@ static bool iscsit_tpg_check_network_portal(
    break;
    }
    spin_unlock(&tpg->tpg_np_lock);
    +
    + if (match)
    + break;
    }
    spin_unlock(&tiqn->tiqn_tpg_lock);

    --
    2.34.1
    \
     
     \ /
      Last update: 2022-02-03 21:32    [W:2.459 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site