lkml.org 
[lkml]   [2022]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.16 12/52] net/sunrpc: fix reference count leaks in rpc_sysfs_xprt_state_change
    Date
    From: Xiyu Yang <xiyuyang19@fudan.edu.cn>

    [ Upstream commit 776d794f28c95051bc70405a7b1fa40115658a18 ]

    The refcount leak issues take place in an error handling path. When the
    3rd argument buf doesn't match with "offline", "online" or "remove", the
    function simply returns -EINVAL and forgets to decrease the reference
    count of a rpc_xprt object and a rpc_xprt_switch object increased by
    rpc_sysfs_xprt_kobj_get_xprt() and
    rpc_sysfs_xprt_kobj_get_xprt_switch(), causing reference count leaks of
    both unused objects.

    Fix this issue by jumping to the error handling path labelled with
    out_put when buf matches none of "offline", "online" or "remove".

    Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
    Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
    Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/sunrpc/sysfs.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/net/sunrpc/sysfs.c b/net/sunrpc/sysfs.c
    index 2766dd21935b8..77e7d011c1ab1 100644
    --- a/net/sunrpc/sysfs.c
    +++ b/net/sunrpc/sysfs.c
    @@ -295,8 +295,10 @@ static ssize_t rpc_sysfs_xprt_state_change(struct kobject *kobj,
    online = 1;
    else if (!strncmp(buf, "remove", 6))
    remove = 1;
    - else
    - return -EINVAL;
    + else {
    + count = -EINVAL;
    + goto out_put;
    + }

    if (wait_on_bit_lock(&xprt->state, XPRT_LOCKED, TASK_KILLABLE)) {
    count = -EINTR;
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-02-03 21:30    [W:5.634 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site