Messages in this thread | | | Date | Thu, 3 Feb 2022 09:35:30 +0100 | Subject | Re: [PATCH v1 1/1] serial: core: Drop duplicate NULL check in uart_*shutdown() | From | Jiri Slaby <> |
| |
On 02. 02. 22, 17:56, Andy Shevchenko wrote: > The free_page(addr), which becomes free_pages(addr, 0) checks addr > against 0. No need to repeat this check in the callers. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
> --- > drivers/tty/serial/serial_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c > index 57f472268b6d..59f93040d807 100644 > --- a/drivers/tty/serial/serial_core.c > +++ b/drivers/tty/serial/serial_core.c > @@ -328,8 +328,7 @@ static void uart_shutdown(struct tty_struct *tty, struct uart_state *state) > state->xmit.buf = NULL; > spin_unlock_irqrestore(&uport->lock, flags); > > - if (xmit_buf) > - free_page((unsigned long)xmit_buf); > + free_page((unsigned long)xmit_buf); > } > > /** > @@ -1621,8 +1620,7 @@ static void uart_tty_port_shutdown(struct tty_port *port) > state->xmit.buf = NULL; > spin_unlock_irq(&uport->lock); > > - if (buf) > - free_page((unsigned long)buf); > + free_page((unsigned long)buf); > } > > static void uart_wait_until_sent(struct tty_struct *tty, int timeout)
thanks, -- js suse labs
| |