Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 3 Feb 2022 11:33:19 -0800 | Subject | Re: [PATCH] gcc-plugins/stackleak: Use noinstr in favor of notrace |
| |
I was going to apply your patch, but then I read your note:
On Tue, Feb 1, 2022 at 4:19 PM Kees Cook <keescook@chromium.org> wrote: > > Is it correct to exclude .noinstr.text here? That means any functions called in > there will have their stack utilization untracked. This doesn't seem right to me, > though. Shouldn't stackleak_track_stack() just be marked noinstr instead?
... and yes, it seems like stackleak_track_stack() should just be 'noinstr' just like you made stackleak_erase().
So I've dropped the patch to see what happens.
If you decide this is the right patch after all, you can just re-send it.
Linus
| |