Messages in this thread | | | Date | Thu, 3 Feb 2022 18:30:39 +0100 | Subject | Re: [PATCH 3/8] rtla/osnoise_top: Fix segmentation fault when failing to enable -t | From | Daniel Bristot de Oliveira <> |
| |
On 2/3/22 17:43, Steven Rostedt wrote: > On Thu, 3 Feb 2022 11:41:26 -0500 > Steven Rostedt <rostedt@goodmis.org> wrote: > >> Wouldn't these four patches be more robust if you just initialized record >> (and tool) to NULL, and change osnoise_destroy_tool() to: > And if you do this, it should be one patch, not four.
Yeah, it works. The order would still be wrong, but it would be just an esthetic thing.
I will send a v2 removing these four patches, and adding a patch with your suggestion.
[ thinking aloud, is it possible to have multiple Fixes:? well, adding just one would also solve the issue, and... we are still in the same release ]
Thanks, -- Daniel
| |