Messages in this thread | | | Date | Thu, 3 Feb 2022 20:14:11 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] ax25: fix reference count leaks of ax25_dev |
| |
On Thu, Feb 03, 2022 at 11:08:11PM +0800, Duoming Zhou wrote: > The previous commit d01ffb9eee4a ("ax25: add refcount in ax25_dev > to avoid UAF bugs") introduces refcount into ax25_dev, but there > are reference leak paths in ax25_ctl_ioctl(), ax25_fwd_ioctl(), > ax25_rt_add(), ax25_rt_del() and ax25_rt_opt(). > > This patch uses ax25_dev_put() and adjusts the position of > ax25_addr_ax25dev() to fix reference cout leaks of ax25_dev. > > Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs") > Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> > ---
Much better, thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |