Messages in this thread | | | Date | Thu, 3 Feb 2022 08:14:41 -0800 | Subject | Re: [PATCH v4] sched/fair: Fix fault in reweight_entity | From | Tadeusz Struk <> |
| |
On 2/3/22 01:40, Dietmar Eggemann wrote: >> -static void set_load_weight(struct task_struct *p, bool update_load) >> +static void set_load_weight(struct task_struct *p) >> { >> int prio = p->static_prio - MAX_RT_PRIO; >> struct load_weight *load = &p->se.load; >> + bool update_load = !(READ_ONCE(p->__state) & TASK_NEW); > nit-pick: reverse fir tree order > > cat Documentation/process/maintainer-tip.rst | grep -A 10 "Variable > declarations" > > I was able to recreate the initial issue with the reproducer on arm64 > Juno-r0 with CONFIG_CGROUP_SCHED=y . > > Reviewed-by: Dietmar Eggemann<dietmar.eggemann@arm.com>
Thanks for reviewing. I will send a v5 soon.
-- Thanks, Tadeusz
| |