Messages in this thread | | | Date | Thu, 3 Feb 2022 15:09:32 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 1/2] EDAC/amd64: Set memory type per DIMM |
| |
On Thu, Feb 03, 2022 at 02:19:19PM +0100, William Roche wrote: > As we are moving the dram_type cached date from pvt to umc for family >= > 0x17, should we also add a small comment for the dram_type field in the > amd64_pvt structure to indicate that ?
Who would be that comment for? People who are looking at the code, so that they know which is which?
> Something like that for example: > > @@ -385,7 +385,7 @@ > /* place to store error injection parameters prior to issue */ > struct error_injection injection; > > - /* cache the dram_type */ > + /* cache the dram_type for family<0x17 */ > enum mem_type dram_type; > > struct amd64_umc *umc; /* UMC registers */ > > > Just a suggestion. > The code looks good to me. > > Reviewed-by: William Roche <william.roche@oracle.com> > > W.
Btw, I'd appreciate it if you do not top-post.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |